Python-side fix for expecting NaN in JSON #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This was referenced Sep 26, 2023
CodyCBakerPhD
approved these changes
Sep 26, 2023
|
Much less hacky than |
CodyCBakerPhD
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on Python instead of JavaScript to handle expected NaN values in the JSON metadata (unlike #374).
Instead of allowing non-compliant JSON on the browser (which doesn't work when passing the object back to Python), this approach replaces
Nonevalues where numbers are expected withNaNon the Python side, while convertingNaNvalues toNonebefore passing to JavaScript.Since this is primarily testing Ophys interfaces (#177), the
Ophysmetadata field is ignored in this PR so we can work on those interactions in a follow-up (related to #176).